Feature: Restart as admin & use New-NetNeighbor / Remove-NetNeighbor by BornToBeRoot · Pull Request #3403 · BornToBeRoot/NETworkManager

BornToBeRoot · 2026-04-29T22:07:51Z

Changes proposed in this pull request

This pull request implements a comprehensive rename and refactor of the application's "ARP Table" feature, transitioning it to "Neighbor Table" to better reflect support for both IPv4 ARP and IPv6 NDP. It updates code, resources, and documentation to use the new terminology throughout, while maintaining backward compatibility for legacy settings. Additionally, it introduces localization support for neighbor states and improves resource naming consistency.

Major terminology and feature refactor:

Renamed the ARPTable application and related documentation identifiers to NeighborTable, updating all code references, resource strings, and documentation links accordingly. The obsolete ARPTable enum value is retained (marked [Obsolete]) for backward compatibility with old settings files. [1] [2] [3] [4] [5] [6] [7] [8]
Updated resource files and localization to replace "ARP Table" with "Neighbor Table", and added new localized strings for neighbor states and related messages. [1] [2]

Localization and converter enhancements:

Added a new NeighborStateToStringConverter to convert NeighborState enum values to localized strings, and registered a new NeighborState resource identifier for translation. [1] [2]

Resource and naming consistency improvements:

Renamed the resource key and string for group/domain from GroupDomainName to GroupDomain for clarity and consistency. [1] [2]

Documentation and project structure:

Added a reference in AGENTS.md to the root project guidelines and conventions.

Versioning:

Updated assembly version numbers to 2026.5.3.0.

Related issue(s)

Fixes Refactor ARP Table → Neighbor Table (IPv4 + IPv6) #3402

To-Do

Update documentation to reflect this changes
Update changelog to reflect this changes

Contributing

By submitting this pull request, I confirm the following:

I have read and understood the contributing guidelines and the code of conduct.
I have have added my name, username or email to the contributors list or don't want to.
The code or resource is compatible with the GNU General Public License v3.0.

Copilot

Pull request overview

This PR updates the ARP Table feature to better align with the “admin-gated modifications” UX pattern used elsewhere (e.g., Firewall), and moves ARP write operations into an in-process PowerShell runspace with a shared lock.

Changes:

Add admin-only gating for ARP table modification commands, including a “Restart as admin” command and a read-only banner when not elevated.
Refactor ARP modification operations to use a shared PowerShell Runspace and SemaphoreSlim for serialized execution; remove the legacy UAC-cancel event flow.
Add a new localized string for the ARP admin read-only message; remove an unused using directive.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
Source/NETworkManager/Views/FirewallView.xaml.cs	Removes an unused `System.Windows.Input` using.
Source/NETworkManager/Views/ARPTableView.xaml	Adds a non-admin banner and “Restart as admin” button; wires visibility to `ConfigurationManager.Current.IsAdmin`.
Source/NETworkManager/ViewModels/ARPTableViewModel.cs	Introduces `IsModifying`, gates modify commands behind admin + in-flight flags, and adds `RestartAsAdminCommand`.
Source/NETworkManager.Models/Network/ARP.cs	Adds shared PowerShell runspace + lock; converts write ops to static async methods executed in-process.
Source/NETworkManager.Localization/Resources/Strings.resx	Adds `ARPTableAdminMessage` string.
Source/NETworkManager.Localization/Resources/Strings.Designer.cs	Adds the strongly-typed accessor for `ARPTableAdminMessage`.

Files not reviewed (1)

Source/NETworkManager.Localization/Resources/Strings.Designer.cs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 42 out of 52 changed files in this pull request and generated 7 comments.

Files not reviewed (1)

Source/NETworkManager.Localization/Resources/Strings.Designer.cs: Language not supported

Comments suppressed due to low confidence (1)

Source/NETworkManager/ViewModels/NeighborTableViewModel.cs:374

AddEntryAction sets IsModifying=true and then awaits GetInterfacesAsync / shows the child window without a surrounding try/finally. If GetInterfacesAsync or ShowChildWindowAsync throws, IsModifying will remain true and the view will stay stuck with modify/refresh commands disabled. Wrap this method body in try/catch/finally (and surface an error message) so IsModifying is always reset on failure.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 42 out of 52 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

Source/NETworkManager.Localization/Resources/Strings.Designer.cs: Language not supported

Comments suppressed due to low confidence (1)

Source/NETworkManager/ViewModels/NeighborTableViewModel.cs:336

AddEntryAction() sets IsModifying = true before awaiting NeighborTable.GetInterfacesAsync(), but there’s no try/finally around that await. If GetInterfacesAsync() throws (e.g., NetworkInterface APIs fail), IsModifying will remain true and permanently disable refresh/modify commands for the view. Consider moving IsModifying = true to after the interface list is loaded, or wrapping the whole method in try/catch/finally that always resets IsModifying on failure (and shows an error message).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+/// <summary>
+    /// Ensures that only one PowerShell pipeline runs on <see cref="SharedRunspace"/> at a time.
+    /// </summary>
+    private static readonly SemaphoreSlim Lock = new(1, 1);
+
+    /// <summary>Protects reads and writes to <see cref="_interfaceAliasCache"/> and <see cref="_interfaceAliasCacheExpiry"/>.</summary>
+    private static readonly Lock InterfaceAliasCacheLock = new();
+


…oot/NETworkManager into feature/neighbor-table

Feature: Restart as admin & use New-NetNeighbor / Remove-NetNeighbor

652b401

Copilot AI review requested due to automatic review settings April 29, 2026 22:07

github-actions Bot added this to the next-release milestone Apr 29, 2026

BornToBeRoot added 🚀 feature-request 🦀 Claude labels Apr 29, 2026

Copilot started reviewing on behalf of BornToBeRoot April 29, 2026 22:08 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread Source/NETworkManager/ViewModels/NeighborTableViewModel.cs

Comment thread Source/NETworkManager.Models/Network/ARP.cs Outdated

Comment thread Source/NETworkManager.Models/Network/ARP.cs Outdated

BornToBeRoot added 6 commits April 30, 2026 22:11

Merge branch 'main' into feature/neighbor-table

913098f

Feature: Neighbor Table

cad77ab

Feature: Resolve IPv6 NDP in IPScanner

43ceb2c

Update docusaurus.config.js

dee02fc

Merge branch 'main' into feature/neighbor-table

8672d07

Feature: Neighbor Table

5a9b5f0

BornToBeRoot requested a review from Copilot May 3, 2026 19:30

Copilot started reviewing on behalf of BornToBeRoot May 3, 2026 19:31 View session

Chore: Rename agents md

f3ddd23

Copilot AI reviewed May 3, 2026

View reviewed changes

Fix: Based on Copilot feedback

879e5db

BornToBeRoot requested a review from Copilot May 3, 2026 20:31

Merge branch 'main' into feature/neighbor-table

1c66142

Copilot started reviewing on behalf of BornToBeRoot May 3, 2026 20:31 View session

BornToBeRoot added 📖 documentation 🛠️ code-cleanup labels May 3, 2026

Copilot AI reviewed May 3, 2026

View reviewed changes

BornToBeRoot added 2 commits May 3, 2026 22:40

Fix: Based on Copilot feedback

54fc1d2

Merge branch 'feature/neighbor-table' of https://github.com/BornToBeR…

c30d415

…oot/NETworkManager into feature/neighbor-table

BornToBeRoot added the ✅ LGTM label May 3, 2026

mergify Bot merged commit 3e80653 into main May 3, 2026
5 checks passed

mergify Bot deleted the feature/neighbor-table branch May 3, 2026 20:51

Copilot AI mentioned this pull request May 3, 2026

Blog post: Neighbor Table supersedes ARP Table – supporting IPv6 #3408

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Restart as admin & use New-NetNeighbor / Remove-NetNeighbor#3403

Feature: Restart as admin & use New-NetNeighbor / Remove-NetNeighbor#3403
mergify[bot] merged 12 commits intomainfrom
feature/neighbor-table

BornToBeRoot commented Apr 29, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

BornToBeRoot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this pull request

Related issue(s)

To-Do

Contributing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BornToBeRoot commented Apr 29, 2026 •

edited

Loading